[PATCH] D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 8 15:14:17 PST 2020
sbc100 added a comment.
One side effect is that that defs in this file that use classes from the non-atomic memory file such as `LoadPatImmOff` and `LoadPatImmOff` will no longer have the `HasAtomics` as part of their `Requires`. Does this seems reasonble?
I think this means that if atomic load/store instructions make is as far as instruction selection in non-atomic build they will success. However in practice they should never get that far because we have the atomics lowering pass that should boil them all away.
This doesn't effect class that are defined in this file such as WaitPatNoOffset, and NotifyPatImmOff since we can add the `HasAtomics` there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92744/new/
https://reviews.llvm.org/D92744
More information about the llvm-commits
mailing list