[PATCH] D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 16:24:00 PST 2020


aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrAtomics.td:232
 // Select loads with no constant offset.
-let Predicates = [HasAtomics] in {
 defm : LoadPatNoOffset<i32, atomic_load_32, "ATOMIC_LOAD_I32">;
----------------
Good point. Maybe we can restore these for load/store patterns? (This and similar `Predicates` below) These patterns don't seem to contain PIC related predicates anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92744/new/

https://reviews.llvm.org/D92744



More information about the llvm-commits mailing list