[PATCH] D92744: [WebAssembly] Fix code generated for atomic operations in PIC mode

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 12:17:26 PST 2020


tlively accepted this revision.
tlively added a comment.

"were being honored" => "were not being honored" in the patch description.

> I believe that all the instrucitons that don't have Requires explcity bottom out in ATOMIC_I and ATOMIC_NRI which have HasAtomics so this should not remove this predicate from any patterns (at least that is the idea).

This might run into the issue that `Requires` don't seem to do anything on instruction definitions, so we need to have it on the `Pat`s. The fix of removing the `let Predicates = ...` in favor of repeating the predicate for each pattern looks good, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92744/new/

https://reviews.llvm.org/D92744



More information about the llvm-commits mailing list