[PATCH] D92631: correcting X86OutgoingValueHandler typo (NFC)

[Chris Sears via Phabricator via llvm-commits]

CSears added a comment.

Yes.  CallLowering::handleAssignments() calls the isIncomingArgumentHandler() getter.

Arm and AArch64 subclass from CallLowering::OutgoingValueHandler and CallLowering::IncomingValueHandler. No problem there. X86 has the typo.

PPC and RISCV don't create value handlers. No problem there.
AMDGPU subclasses from its own ValueHandler and sets isComing accordingly. No problem there.

Mips creates its own MipsHandler (which doesn't subclass from ValueHandler) and subclasses from that. It doesn't set isIncoming at all (defaults to false) and doesn't use it. It also doesn't call handleAssignments() and instead has its own handle(). There doesn't seem to be a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92631/new/

https://reviews.llvm.org/D92631