[PATCH] D92631: correcting X86OutgoingValueHandler typo (NFC)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D92631#2434315 <https://reviews.llvm.org/D92631#2434315>, @CSears wrote:

> Yes.  CallLowering::handleAssignments() calls the isIncomingArgumentHandler() getter.
>
> Arm and AArch64 subclass from CallLowering::OutgoingValueHandler and CallLowering::IncomingValueHandler. No problem there. X86 has the typo.
>
> PPC and RISCV don't create value handlers. No problem there.
> AMDGPU subclasses from its own ValueHandler and sets isComing accordingly. No problem there.
>
> Mips creates its own MipsHandler (which doesn't subclass from ValueHandler) and subclasses from that. It doesn't set isIncoming at all (defaults to false) and doesn't use it. It also doesn't call handleAssignments() and instead has its own handle(). There doesn't seem to be a problem.

X86 has a typo and calls handleAssignments() which uses isIncomingArgumentHandler(). So why is this patch NFC? Is X86 not using a code path in handleAssignments() cares about isIncomingArgumentHandler()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92631/new/

https://reviews.llvm.org/D92631