[PATCH] D92631: correcting X86OutgoingValueHandler typo (NFC)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 09:50:11 PST 2020


arsenm added a comment.

In D92631#2433822 <https://reviews.llvm.org/D92631#2433822>, @CSears wrote:

> I don't think it does but it could because IncomingValueHandler passes true
> to the ValueHandler constructor and OutgoingValueHandler passes false. That
> boolean then gets stored in IsIncoming. However, the only code which uses
> IsIncoming is AMDGPU.

The generic code also checks it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92631/new/

https://reviews.llvm.org/D92631



More information about the llvm-commits mailing list