[PATCH] D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 01:17:48 PST 2020


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4031
+    bool IsMIMG = Mnemo.startswith("image_");
+    if (IsMIMG && isGFX10() &&
+        getImmLoc(AMDGPUOperand::ImmTyDim, Operands) == IDLoc) {
----------------
Please use `isGFX10Plus`, which I just added in D92092.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92085/new/

https://reviews.llvm.org/D92085



More information about the llvm-commits mailing list