[PATCH] D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4032
+    if (IsMIMG && isGFX10() &&
+        getImmLoc(AMDGPUOperand::ImmTyDim, Operands) == IDLoc) {
+      return Error(IDLoc, "missing dim modifier");
----------------
dp wrote:
> rampitec wrote:
> > It is not necessarily "dim". For example image_bvh* do not have dim modifier.
> Thanks. I did not know about these instructions. I thought that at least in gfx1010 all MIMG opcodes require DIM.
You can query if opcode has dim operand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92085/new/

https://reviews.llvm.org/D92085