[PATCH] D92085: [AMDGPU][MC][GFX10] Improved diagnistic message for image instructions w/o DIM modifier
Dmitry Preobrazhensky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 26 02:13:44 PST 2020
dp added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4031
+ bool IsMIMG = Mnemo.startswith("image_");
+ if (IsMIMG && isGFX10() &&
+ getImmLoc(AMDGPUOperand::ImmTyDim, Operands) == IDLoc) {
----------------
foad wrote:
> Please use `isGFX10Plus`, which I just added in D92092.
Sure, thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92085/new/
https://reviews.llvm.org/D92085
More information about the llvm-commits
mailing list