[PATCH] D91449: [RISCV] Add RISCVISD::ROLW/RORW use those for custom legalizing i32 rotl/rotr on RV64IZbb.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 20 04:04:40 PST 2020


frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM. We can always revisit the `grev`/`ror` question as it applies both before and after this patch. At any rate, matching `rotl`/`rotr` to `roli` is a more logical default.

One thing: I'm surprised by the lack of test changes involving `rol` - are we missing some coverage?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91449/new/

https://reviews.llvm.org/D91449



More information about the llvm-commits mailing list