[PATCH] D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 23:15:36 PST 2020


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cpp:71
 
-#if SANITIZER_CAN_FAST_UNWIND
+#if SANITIZER_CAN_FAST_UNWIND && !defined(__sparc__)
+// Fake stacks don't meet SPARC UnwindFast requirements.
----------------
Not very important but I would prefer conditional disable like here

https://github.com/llvm/llvm-project/blob/master/lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91618/new/

https://reviews.llvm.org/D91618



More information about the llvm-commits mailing list