[PATCH] D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 06:38:02 PST 2020
ro added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cpp:72
+#if SANITIZER_CAN_FAST_UNWIND && !defined(__sparc__)
+// Fake stacks don't meet SPARC UnwindFast requirements.
----------------
vitalybuka wrote:
> BufferedStackTrace::UnwindFast does not work on fake stack? Can that be fixed?
In `sanitizer_stacktrace_sparc.cpp` you see that SPARC `UnwindFast` has to peek into the parent frame to get at the window save area. Modelling all this just for the benefit of fake stacks and a couple of testcases seems like total overkill to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91618/new/
https://reviews.llvm.org/D91618
More information about the llvm-commits
mailing list