[PATCH] D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC

[Rainer Orth via Phabricator via llvm-commits]

ro added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cpp:71
 
-#if SANITIZER_CAN_FAST_UNWIND
+#if SANITIZER_CAN_FAST_UNWIND && !defined(__sparc__)
+// Fake stacks don't meet SPARC UnwindFast requirements.
----------------
vitalybuka wrote:
> Not very important but I would prefer conditional disable like here
> 
> https://github.com/llvm/llvm-project/blob/master/lldb/unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp
While this would mean touching every single test instead of wrapping the whole block, OTOH it allows to skip just those tests that `FAIL` much less verbosely than the
```
#if SANITIZER_CAN_FAST_UNWIND && !defined(__sparc__)
```
form.  I like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91618/new/

https://reviews.llvm.org/D91618