[PATCH] D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro added inline comments.


================
Comment at: compiler-rt/test/sanitizer_common/CMakeLists.txt:65-70
   if(${tool} STREQUAL "asan")
     list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
   endif()
+  if(OS_NAME MATCHES "SunOS" AND ${tool} STREQUAL "asan")
+    list(REMOVE_ITEM TEST_ARCH x86_64)
+  endif()
----------------
vitalybuka wrote:
> 
Unless I'm mistaken, that would disable the `SanitizerCommon-ubsan-x86_64-SunOS` tests which do work just fine, just like the code above (l.65-67) only disables the ASan tests on sparc*.


================
Comment at: compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp:6
+// No libutil.
+// XFAIL: solaris
 
----------------
vitalybuka wrote:
> XFAIL or UNSUPPORTED?
> I assume that XFAIL is useful when thing is consistently broken and it should be fixed in future.
> If you don't expect -lutil supported it should be probably UNSUPPORTED
You're right: looking at the contents of `libutil` on Linux I see that most (all) of those functions live in `libc` on Solaris.  I hadn't even heard about `libutil` ever before, so I'm pretty certain this won't be introduced.

I'll make it `UNSUPPORTED`, unless I get around to implementing `%libutil`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91606/new/

https://reviews.llvm.org/D91606