[PATCH] D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris

[Rainer Orth via Phabricator via llvm-commits]

ro added inline comments.


================
Comment at: compiler-rt/test/sanitizer_common/CMakeLists.txt:65-70
   if(${tool} STREQUAL "asan")
     list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
   endif()
+  if(OS_NAME MATCHES "SunOS" AND ${tool} STREQUAL "asan")
+    list(REMOVE_ITEM TEST_ARCH x86_64)
+  endif()
----------------
ro wrote:
> vitalybuka wrote:
> > 
> Unless I'm mistaken, that would disable the `SanitizerCommon-ubsan-x86_64-SunOS` tests which do work just fine, just like the code above (l.65-67) only disables the ASan tests on sparc*.
> Unless I'm mistaken, that would disable the `SanitizerCommon-ubsan-x86_64-SunOS` tests which do work just fine, just like the code above (l.65-67) only disables the ASan tests on sparc*.

I've tried this now and indeed with your suggested change the `SanitizerCommon-ubsan-x86_64-SunOS` tests change from `PASS` to `UNSUPPORTED`.  So I'm going to leave this as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91606/new/

https://reviews.llvm.org/D91606