[PATCH] D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/test/sanitizer_common/CMakeLists.txt:65-70
   if(${tool} STREQUAL "asan")
     list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
   endif()
+  if(OS_NAME MATCHES "SunOS" AND ${tool} STREQUAL "asan")
+    list(REMOVE_ITEM TEST_ARCH x86_64)
+  endif()
----------------



================
Comment at: compiler-rt/test/sanitizer_common/TestCases/Posix/getpass.cpp:6
+// No libutil.
+// XFAIL: solaris
 
----------------
XFAIL or UNSUPPORTED?
I assume that XFAIL is useful when thing is consistently broken and it should be fixed in future.
If you don't expect -lutil supported it should be probably UNSUPPORTED


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91606/new/

https://reviews.llvm.org/D91606