[PATCH] D91670: Fix crash after looking up dwo_id=0 in CU index.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:1
+# REQUIRES: x86-registered-target
+
----------------
I'd find it useful if there was a top-level comment in this test explaining the purpose of this test.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:7
+
+# This expected output is very uninteresting, but it's better than a crash.
+# CHECK: ??:0:0
----------------
A number of our newer binary utility tests use the pattern of `##` for comments, to clearly distinguish them from lit and FileCheck lines. Could you do that in this test too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91670/new/

https://reviews.llvm.org/D91670