[PATCH] D91670: Fix crash after looking up dwo_id=0 in CU index.

[Pavel Labath via Phabricator via llvm-commits]

labath added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:93
+        .section        .debug_cu_index,"", at progbits
+        .short  2                       # DWARF version number
+        .short  0                       # Reserved
----------------
MaskRay wrote:
> For version 2, the field should be `.long 2`
> 
> (The difference matters if this is big-endian)
This is kind of my fault, as this source is adapted from one of my tests. DWP version 2 (unofficial fission proposal) does indeed use a single long field, but then the official standardized format (version 5) uses two short fields -- and I have mixed the two up.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:105
+
+.irpc I,1
+        .long .Lcu_begin\I-.debug_info.dwo
----------------
MaskRay wrote:
> The two loops can be merged.
Well, if it's going to have just one iteration, then I guess the loops can just be deleted altogether.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91670/new/

https://reviews.llvm.org/D91670