[PATCH] D91670: Fix crash after looking up dwo_id=0 in CU index.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 21:38:27 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:48
+        .section        .debug_addr,"", at progbits
+        .quad   A\I
+        .quad   F\I
----------------
`A\I` is undefined. Consider defining the symbol to be more realistic.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf-zero-signature-not-found.s:105
+
+.irpc I,1
+        .long .Lcu_begin\I-.debug_info.dwo
----------------
The two loops can be merged.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91670/new/

https://reviews.llvm.org/D91670



More information about the llvm-commits mailing list