[PATCH] D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools

Tue Nov 17 16:32:44 PST 2020

MaskRay added inline comments.

================
Comment at: llvm/test/LTO/Resolution/X86/diagnostic-handler-remarks-with-hotness.ll:30
+; RUN:           -r %t.bc,main,px -o %t.o %t.bc
+; RUN: not FileCheck %s -check-prefix=YAML < %t.t301.yaml
+
----------------
weiwang wrote:
> MaskRay wrote:
> > We don't use `not FileCheck`. If you want to check a pattern does not exist, use https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-not-directive
> Sorry, I am not sure how to apply "CHECK-EMPTY" in this case. The input is empty, and I think "CHECK-EMPTY" assumes a non-empty input (requires a "CHECK" line above it). 
Use `| count 0` to check empty output

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809