[PATCH] D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools

[Wei Wang via Phabricator via llvm-commits]

weiwang added inline comments.


================
Comment at: llvm/include/llvm/Remarks/HotnessThresholdParser.h:47
+public:
+  HotnessThresholdParser(cl::Option &O) : cl::parser<Optional<uint64_t>>(O) {}
+
----------------
MaskRay wrote:
> Regarding the MSVC compiliation issue. If you use llvm::Optional here, does it work?
Good point! I completed overlooked this place. I will give it a try in the next revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809