[PATCH] D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools

[Wei Wang via Phabricator via llvm-commits]

weiwang added inline comments.


================
Comment at: llvm/include/llvm/LTO/Config.h:128
+  /// The threshold is an Optional value, which maps to one of the 3 states:
+  /// 1. 0            => threshold disabled. All emarks will be printed.
+  /// 2. positive int => manual threshold by user. Remarks with hotness exceed
----------------
MaskRay wrote:
> Does swapping the meaning of 0 and None make more sense? `None` looks like a better default value.
`None` means `unknown`, more of a transient value. It would be updated by the actual hotness value from PSI later. Also currently `0` is treated as `disabled`, I figured keeping its current meaning requires less change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809