[PATCH] D91339: [X86] Include %rip for 32-bit RIP-relative relocs for x32

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 00:39:58 PST 2020


hvdijk added a comment.

In D91339#2392968 <https://reviews.llvm.org/D91339#2392968>, @MaskRay wrote:

> This is correct. Probably worth mentioning in the subject that this is for x32.

Sure, added. I had also wrongly written "PIC-relative" which should clearly be "RIP-relative", edited that as well.

> I wonder whether a `fastisel-*` test file is more suitable.

I had started with a new test, but switched to extending `pic.ll` instead because it was more thorough. I can copy `pic.ll` to `fastisel-pic.ll` and only check x32 fastisel in there, if preferred.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91339/new/

https://reviews.llvm.org/D91339



More information about the llvm-commits mailing list