[PATCH] D91339: [X86] Include %rip for 32-bit RIP-relative relocs for x32

Fri Nov 13 09:36:39 PST 2020

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D91339#2393183 <https://reviews.llvm.org/D91339#2393183>, @hvdijk wrote:

> In D91339#2392968 <https://reviews.llvm.org/D91339#2392968>, @MaskRay wrote:
>
>> This is correct. Probably worth mentioning in the subject that this is for x32.
>
> Sure, added. I had also wrongly written "PIC-relative" which should clearly be "RIP-relative", edited that as well.
>
>> I wonder whether a `fastisel-*` test file is more suitable.
>
> I had started with a new test, but switched to extending `pic.ll` instead because it was more thorough. I can copy `pic.ll` to `fastisel-pic.ll` and only check x32 fastisel in there, if preferred.

It may be fine. Let's wait a bit for other reviewers

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91339/new/

https://reviews.llvm.org/D91339