[PATCH] D90558: [VPlan] Add VPDef class.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 15 09:58:06 PST 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:69
+    Def->removeDefinedValue(this);
+  assert(!Def && "trying to delete a VPValue with a linked VPDef");
+}
----------------
Ayal wrote:
> nit: this assert that removeDefinedValue(V) sets V->Def to null seems a bit redundant; its comment describes what is done if (Def) ...
Yes that's probably over-cautious. I removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90558/new/

https://reviews.llvm.org/D90558



More information about the llvm-commits mailing list