[PATCH] D91346: [AArch64] Add FCMLA AArch64ISD node.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D91346#2391341 <https://reviews.llvm.org/D91346#2391341>, @dmgreen wrote:

> Sounds OK, but I think there's such a thing as splitting up a patch too much! And if it's not possible to add tests for something, that can be a bad sign.

That's a good point! The patch that's using it is D91354 <https://reviews.llvm.org/D91354>, but it relies on a new intrinsic which is still up in the air. I post on llvm-dev to restart the discussion about how to improve support for complex math: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146568.html

> Complex MLA is something that exists in MVE too. I'm not sure what the other part of this looks like yet (I presume it's just matching), but it may be good in the long run to make some of this more target independent, so long as they work in the same way.

If there are very similar instructions in other backends, it might make sense to introduce an independent ISD node in the future, but I am only familiar with the complex math instructions on AArch64 unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91346/new/

https://reviews.llvm.org/D91346