[PATCH] D91346: [AArch64] Add FCMLA AArch64ISD node.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 06:52:09 PST 2020


dmgreen added a comment.

Sounds OK, but I think there's such a thing as splitting up a patch too much! And if it's not possible to add tests for something, that can be a bad sign.

Complex MLA is something that exists in MVE too. I'm not sure what the other part of this looks like yet (I presume it's just matching), but it may be good in the long run to make some of this more target independent, so long as they work in the same way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91346/new/

https://reviews.llvm.org/D91346



More information about the llvm-commits mailing list