[PATCH] D91287: [ARM] Ensure CountReg definition dominates InsertPt when creating t2DoLoopStartTP

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 01:59:45 PST 2020


samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEVPTOptimisationsPass.cpp:233
       InsertPt = &Use;
+  if (!DT->dominates(MRI->getVRegDef(CountReg), &*InsertPt)) {
+    LLVM_DEBUG(dbgs() << "  InsertPt does not dominate CountReg!\n");
----------------
If it doesn't dominate, we're saying that the def is actually the last instruction in the block, right? So can't we make InsertPt = MBB->end()?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91287/new/

https://reviews.llvm.org/D91287



More information about the llvm-commits mailing list