[PATCH] D91287: [ARM] Ensure CountReg definition dominates InsertPt when creating t2DoLoopStartTP

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 11:23:03 PST 2020


dmgreen created this revision.
dmgreen added reviewers: SjoerdMeijer, samtebbs, samparker.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
Herald added a project: LLVM.
dmgreen requested review of this revision.

Of course there was something missing, in this case a check that the def of the count register we are adding to a t2DoLoopStartTP would dominate the insertion point.

In the future, when we remove some of these COPY's in between, the t2DoLoopStartTP will always become the last instruction in the block, preventing this from happening. In the meantime we need to check they are created in a sensible order.


https://reviews.llvm.org/D91287

Files:
  llvm/lib/Target/ARM/MVEVPTOptimisationsPass.cpp
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/count_dominates_start.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91287.304593.patch
Type: text/x-patch
Size: 11409 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201111/ce9398ea/attachment.bin>


More information about the llvm-commits mailing list