[PATCH] D91287: [ARM] Ensure CountReg definition dominates InsertPt when creating t2DoLoopStartTP

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEVPTOptimisationsPass.cpp:233
       InsertPt = &Use;
+  if (!DT->dominates(MRI->getVRegDef(CountReg), &*InsertPt)) {
+    LLVM_DEBUG(dbgs() << "  InsertPt does not dominate CountReg!\n");
----------------
samparker wrote:
> If it doesn't dominate, we're saying that the def is actually the last instruction in the block, right? So can't we make InsertPt = MBB->end()?
The code above it has needed to move the insertion point backwards from the end.

(That will hopefully get cleaned up in a later patch like I said above. It will eventually just become a terminator but at this point there may be copies between that need to use the correct value).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91287/new/

https://reviews.llvm.org/D91287