[PATCH] D90844: [TableGen][SchedModels] Fix read/write variant substitution #2

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 7 10:32:47 PST 2020


evgeny777 added a comment.

> I'm not sure if I see how both halves are related here. Is this a problem that you found, so you altered the A57 to show that issue, so the tablegen code fixes the issue?

Yep, this is a problem I've found after D89777 <https://reviews.llvm.org/D89777> was landed. Modifications to A57 code are required to test it. D89777 <https://reviews.llvm.org/D89777> addressed the case when entire SchedRW couldn't be expanded, this one is actually improvement to which also handles case when some of SchedRW aliases are expanded and some are not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90844/new/

https://reviews.llvm.org/D90844



More information about the llvm-commits mailing list