[PATCH] D90838: [BranchProbabilityInfo] Remove block handles in eraseBlock()

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 21:50:24 PST 2020


yrouban added inline comments.


================
Comment at: llvm/include/llvm/Analysis/BranchProbabilityInfo.h:216
       BPI->eraseBlock(cast<BasicBlock>(getValPtr()));
-      BPI->Handles.erase(*this);
     }
----------------
kazu wrote:
> While you are at this, could you make `BranchProbabilityInfo::Handles` private?
> 
It is private.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90838/new/

https://reviews.llvm.org/D90838



More information about the llvm-commits mailing list