[PATCH] D90838: [BranchProbabilityInfo] Remove block handles in eraseBlock()

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 14:23:06 PST 2020


kazu accepted this revision.
kazu added a comment.
This revision is now accepted and ready to land.

LGTM.  Thanks!



================
Comment at: llvm/include/llvm/Analysis/BranchProbabilityInfo.h:216
       BPI->eraseBlock(cast<BasicBlock>(getValPtr()));
-      BPI->Handles.erase(*this);
     }
----------------
While you are at this, could you make `BranchProbabilityInfo::Handles` private?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90838/new/

https://reviews.llvm.org/D90838



More information about the llvm-commits mailing list