[PATCH] D90838: [BranchProbabilityInfo] Remove block handles in eraseBlock()
Kazu Hirata via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 5 22:07:56 PST 2020
kazu added inline comments.
================
Comment at: llvm/include/llvm/Analysis/BranchProbabilityInfo.h:216
BPI->eraseBlock(cast<BasicBlock>(getValPtr()));
- BPI->Handles.erase(*this);
}
----------------
yrouban wrote:
> kazu wrote:
> > While you are at this, could you make `BranchProbabilityInfo::Handles` private?
> >
> It is private.
Sorry, I missed that. Thank you for checking!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90838/new/
https://reviews.llvm.org/D90838
More information about the llvm-commits
mailing list