[PATCH] D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:161-168
 bool DirectiveLanguage::CheckRecordsValidity() const {
   if (getDirectiveLanguages().size() != 1) {
-    PrintError("A single definition of DirectiveLanguage is needed.");
+    PrintFatalError("A single definition of DirectiveLanguage is needed.");
     return true;
   }
 
   return HasDuplicateClausesInDirectives(getDirectives());
----------------
Nit: Does the return value match the name of this function?

Shouldn't it be like the following?
if records are valid then it is all good (return true).
If records are not valid then it is bad (return false).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90770/new/

https://reviews.llvm.org/D90770