[PATCH] D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:161-168
 bool DirectiveLanguage::CheckRecordsValidity() const {
   if (getDirectiveLanguages().size() != 1) {
-    PrintError("A single definition of DirectiveLanguage is needed.");
+    PrintFatalError("A single definition of DirectiveLanguage is needed.");
     return true;
   }
 
   return HasDuplicateClausesInDirectives(getDirectives());
----------------
kiranchandramohan wrote:
> Nit: Does the return value match the name of this function?
> 
> Shouldn't it be like the following?
> if records are valid then it is all good (return true).
> If records are not valid then it is bad (return false).
Right it is misleading. I'll update that to be consistent between the name and the return value. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90770/new/

https://reviews.llvm.org/D90770