[PATCH] D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 08:55:03 PST 2020


clementval created this revision.
clementval added reviewers: kiranchandramohan, sameeranjoshi, kiranktp, jdoerfert, SouraVX.
Herald added subscribers: llvm-commits, guansong, yaxunl.
Herald added a project: LLVM.
clementval requested review of this revision.
Herald added a subscriber: sstefan1.

Validity check introduce in D90241 <https://reviews.llvm.org/D90241> are a bit too restrict and this patch propose to losen
them a bit. The duplicate clauses is now check only between the three allowed lists and between the
requiredClauses and allowedClauses lists. This allows to enable some check where a clause can be 
required but also appear only once on the directive. We found these kind of restriction useful
on the set directive in OpenACC for example.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90770

Files:
  llvm/include/llvm/Frontend/Directive/DirectiveBase.td
  llvm/test/TableGen/directive3.td
  llvm/utils/TableGen/DirectiveEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90770.302861.patch
Type: text/x-patch
Size: 3797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201104/21b851d2/attachment.bin>


More information about the llvm-commits mailing list