[PATCH] D89712: [CSSPGO][llvm-profgen] Disassemble text sections
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 30 11:03:52 PDT 2020
wenlei added inline comments.
================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:59
+// in memory.
+static uint64_t getELFImageLMAForSec(const object::ELFSectionRef &Sec) {
+ if (const auto *ELFObj = dyn_cast<ELF32LEObjectFile>(Sec.getObject()))
----------------
Can we sink the 4 `getELFImageLMAForSec` manually to avoid duplication and make it more readable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89712/new/
https://reviews.llvm.org/D89712
More information about the llvm-commits
mailing list