[PATCH] D89712: [CSSPGO][llvm-profgen] Disassemble text sections
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 29 10:13:53 PDT 2020
wlei marked 3 inline comments as done.
wlei added inline comments.
================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:114
+ SectionSymbolsTy &Symbols,
+ uint64_t ImageLoadAddr,
+ uint64_t SectionRVA, uint64_t SectSize,
----------------
hoy wrote:
> No need to pass this in as a parameter. Can just use the member field `PreferredBaseAddress` instead.
Thanks for your suggestions, all fixed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89712/new/
https://reviews.llvm.org/D89712
More information about the llvm-commits
mailing list