[PATCH] D89712: [CSSPGO][llvm-profgen] Disassemble text sections

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 11:24:57 PDT 2020


wenlei added a comment.

If it's not too much work, I'd suggest squash the refactoring of your later patch (RVA->Offset etc from https://reviews.llvm.org/D89715) into this one. Upstream patch does not have to map 1:1 to internal patch - squashing, minimizing code churn and grouping by functionality helps make it easier for other reviewers. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89712/new/

https://reviews.llvm.org/D89712



More information about the llvm-commits mailing list