[PATCH] D90425: hwasan: Move fixed shadow behind opaque no-op cast as well.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 16:34:54 PDT 2020


hctim added a comment.

LGTM but will let eugenis make the approval as he's much better versed here.



================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:593
 
 Value *HWAddressSanitizer::getDynamicShadowNonTls(IRBuilder<> &IRB) {
   if (Mapping.Offset != kDynamicShadowSentinel)
----------------
should this be `getShadowNonTls` now (and `getShadowIfunc()` above)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90425/new/

https://reviews.llvm.org/D90425



More information about the llvm-commits mailing list