[PATCH] D90425: hwasan: Move fixed shadow behind opaque no-op cast as well.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 16:40:40 PDT 2020


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/basic.ll:60
-; ABORT-DYNAMIC-SHADOW: call void @llvm.hwasan.check.memaccess.shortgranules(i8* %.hwasan.shadow, i8* %a, i32 0)
-; ABORT-ZERO-BASED-SHADOW: call void @llvm.hwasan.check.memaccess.shortgranules(i8* null, i8* %a, i32 0)
 
----------------
This seems suboptimal in the zero shadow case. But is it even used anywhere?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90425/new/

https://reviews.llvm.org/D90425



More information about the llvm-commits mailing list