[PATCH] D90425: hwasan: Move fixed shadow behind opaque no-op cast as well.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 13:55:16 PDT 2020


pcc created this revision.
pcc added reviewers: eugenis, hctim.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
pcc requested review of this revision.

This is a workaround for poor heuristics in the backend where we can
end up materializing the constant multiple times. This is particularly
bad when using outlined checks because we materialize it for every call
(because the backend considers it trivial to materialize).

As a result the field containing the shadow base value will always
be set so simplify the code taking that into account.

Depends on D90424 <https://reviews.llvm.org/D90424>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90425

Files:
  llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
  llvm/test/Instrumentation/HWAddressSanitizer/basic.ll
  llvm/test/Instrumentation/HWAddressSanitizer/kernel.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90425.301745.patch
Type: text/x-patch
Size: 11233 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201029/a503faeb/attachment.bin>


More information about the llvm-commits mailing list