[PATCH] D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D90299#2362220 <https://reviews.llvm.org/D90299#2362220>, @compnerd wrote:

> I would say `isDLLStorageEnvironment` is a better predicate.

That sounds less specific to me, and would imply that it also would cover mingw targets (which it doesn't).

The current suggested name, `isDLLImportExportMSCompatible`, is more specific, but when I first read it my reaction was that mingw's dllexport/import (in the general cases) for sure works the same as for MSVC - if you consider C functions. So if the name can make it clearer that this covers C++ cases, it'd be more intuitive to me, even though I'm sure it'd become even more of a mouthful then...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90299/new/

https://reviews.llvm.org/D90299