[PATCH] D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I agree, the name could be improved. For prior art, see /Zc:dllexportInlines-, which disables some (but not all) of the dllexport/import semantics in clang-cl.

What we are really talking about here is what should be done when importing or exporting C++ constructs with vague linkage (inline functions, templates). That's what all the affected code has in common. Clang doesn't often use the terminology of vague linkage, so maybe it would be better to use the name comdat somehow.

How about `TargetInfo::shouldDLLImportComdatSymbols`? You could add in "export" (`shouldDLLImportExportComdatSymbols`), but GCC also exports comdat things sometimes, and in the cases where this predicate controls export behavior, it's pretty clear that it needs to be done to support the side which would import the symbol (explicit template instantiations).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90299/new/

https://reviews.llvm.org/D90299