[PATCH] D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Will there be any need to check this in LLVM? If not, I would prefer to put this on `clang::TargetInfo`.



================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:3201
     if (CGM.getVTables().isVTableExternal(RD))
-      return IsDLLImport && !CGM.getTriple().isWindowsItaniumEnvironment()
+      return IsDLLImport && !CGM.getTriple().isDLLImportExportMSCompatible()
                  ? false
----------------
`CGM` also has a `getTarget()` method to get `TargetInfo` if the predicate moves there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90299/new/

https://reviews.llvm.org/D90299