[PATCH] D90162: [llvm][AArch64] Prevent spurious zero extention.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 03:36:45 PDT 2020


fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1171
 
+bool SelectionDAG::isZeroExtendInReg(SDValue Val) const {
+  // assert(NarrowVT.isInteger() && "Unexpected EVT in input.");
----------------
samparker wrote:
> There's so much existing logic around extensions and load widths that I'm struggling to believe that this is really needed... Maybe DAGCombiner::isAndLoadExtLoad can help instead?
Thank you for pointing this out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90162/new/

https://reviews.llvm.org/D90162



More information about the llvm-commits mailing list