[PATCH] D89789: [LLD][ELF] Add --force-tls-variant2 option
    Andrew Ng via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Oct 22 06:19:23 PDT 2020
    
    
  
andrewng added a comment.
In D89789#2345015 <https://reviews.llvm.org/D89789#2345015>, @MaskRay wrote:
> Putting together, I think this option cannot be accepted.
> On the good side, the place you modify is very stable and you usually will not get merge conflict.
OK, no problem and thanks for taking the time to review. To be honest, I had similar concerns but we're in a tricky situation as Edd has explained. Would you consider taking this patch without the `--force-tls-variant2` option, i.e. just the addition of the `TlsVariant` enum and associated changes?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89789/new/
https://reviews.llvm.org/D89789
    
    
More information about the llvm-commits
mailing list