[PATCH] D89789: [LLD][ELF] Add --force-tls-variant2 option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I really appreciate the other areas Andrew has contributed to.G
For this one, it is a non-ABI-conforming variant (whose purpose will make people confused (as I've pointed out)) which will work with no existing ld.so implementations people can find, implemented by neither of the linker we want to be a replacement (GNU ld,gold).
I have asked 3 other folks who have experience in linker and loaders. They are all skeptical about the change.
What makes the case worse is that you can neither confirm nor deny the detail.
(I did want to help. And in a very similar case for Android bionic, I've helped them migrate off an LLD hack.)
This really makes the option a private vendor extension that nobody else can reasonably contribute on this matter.
They cannot make judgement fron the existing material as it is tightly coupled with your private vendor implementation.
Putting together, I think this option cannot be accepted.
On the good side, the place you modify is very stable and you usually will not get merge conflict.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89789/new/

https://reviews.llvm.org/D89789