[PATCH] D89789: [LLD][ELF] Add --force-tls-variant2 option

Thu Oct 22 08:52:04 PDT 2020

MaskRay added a comment.

In D89789#2347084 <https://reviews.llvm.org/D89789#2347084>, @andrewng wrote:

> In D89789#2345015 <https://reviews.llvm.org/D89789#2345015>, @MaskRay wrote:
>
>> Putting together, I think this option cannot be accepted.
>> On the good side, the place you modify is very stable and you usually will not get merge conflict.
>
> OK, no problem and thanks for taking the time to review. To be honest, I had similar concerns but we're in a tricky situation as Edd has explained.

> Would you consider taking this patch without the `--force-tls-variant2` option, i.e. just the addition of the `TlsVariant` enum and associated changes?

Sorry, I am afraid I won't. Building an abstraction and duplicating a switch in Driver.cpp just seem to make the code harder to read. This piece of code is quite stable and it should not cause you much (if any) rebase trouble.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89789/new/

https://reviews.llvm.org/D89789